ref(store): CORS pre-flight cleanup #13421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved CORS pre-flight functionality from the Store code to a decorator.
mitsuhiko
suggested changes
May 28, 2019
Contributor
mitsuhiko
left a comment
mitsuhiko
left a comment
There was a problem hiding this comment.
Now we’re doing the access check just in options. I thought we should instead do it in the dispatch itself and just return okay from the preflight.
Options response independent of project
Contributor
Author
|
OPTIONS request now return 204 on any request |
mitsuhiko
suggested changes
May 29, 2019
# Conflicts: # src/sentry/web/api.py
mitsuhiko
previously requested changes
May 31, 2019
untitaker
approved these changes
Jun 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved CORS pre-flight functionality from the Store code to a decorator.